Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20104 )
Change subject: IMPALA-11842: Improve memory estimation for Aggregate ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/20104/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20104/7//COMMIT_MSG@19 PS7, Line 19: PREAGG_BYTES_LIMIT > What's the expected behavior if someone sets both, PREAGG_BYTES_LIMIT and L For streaming aggregation node, PREAGG_BYTES_LIMIT will win over LARGE_AGG_MEM_THRESHOLD if. both is set. This will keep the old behavior (mem estimate capped at PREAGG_BYTES_LIMIT). http://gerrit.cloudera.org:8080/#/c/20104/7/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20104/7/common/thrift/ImpalaService.thrift@813 PS7, Line 813: PREAGG_BYTES_LIMIT > Maybe also clarify that, if 'PREAGG_BYTES_LIMIT' is also set then it's used Done. Added clarification in this thrift doc. http://gerrit.cloudera.org:8080/#/c/20104/7/common/thrift/ImpalaService.thrift@817 PS7, Line 817: // streaming preaggregation node and PREAGG_BYTES_LIMIT is set, then PREAGG_BYTES_LIMIT > Do we also need to support disabling this query option i.e. setting LARGE_A Done. Setting value <= 0 will effectively disable this option. Note that setting AGG_MEM_CORRELATION_FACTOR=1.0 will also effectively keep the memory estimate unchanged. -- To view, visit http://gerrit.cloudera.org:8080/20104 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4b4b2e519ee89f0a13fdb62d0471ee4047f6421 Gerrit-Change-Number: 20104 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Jul 2023 23:36:01 +0000 Gerrit-HasComments: Yes
