Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20143 )
Change subject: IMPALA-11941: (Addendum) ease testing other JDKs ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java: http://gerrit.cloudera.org:8080/#/c/20143/6/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@50 PS6, Line 50: if (!StringUtils.isEmpty(System.getenv("TEST_JDK_VERSION")) || : !StringUtils.isEmpty(System.getenv("TEST_JAVA_HOME_OVERRIDE"))) { : // Don't restart Kudu with a different Java version. : return; : } I'm wonder if there is a way we can fix up the environment variables so Kudu restarts with system JDK. We already pass in a whole environment to the Kudu start command. At the same place we use TEST_JDK_VERSION and TEST_JAVA_HOME_OVERRIDE to set IMPALA_JAVA_HOME_OVERRIDE/IMPALA_JDK_VERSION, we could stash the system JDK in an environment variable. Then, here we override Kudu's JAVA_HOME if TEST_JDK_VERSION/TEST_JAVA_HOME_OVERRIDE is set? -- To view, visit http://gerrit.cloudera.org:8080/20143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b5515efd9537d63b843dbc42aa93b376efce00 Gerrit-Change-Number: 20143 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 12 Jul 2023 19:51:54 +0000 Gerrit-HasComments: Yes
