Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20187 )
Change subject: IMPALA-12239: BitWidthZeroRepeated seems to be flaky ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h File be/src/util/bit-stream-utils.inline.h: http://gerrit.cloudera.org:8080/#/c/20187/1/be/src/util/bit-stream-utils.inline.h@249 PS1, Line 249: if (LIKELY(buffer_pos_ != buffer_end_)) { > I don't think that has to be true. I don't know if there is a sensible use Ok, that makes sense. The only reason I ask is that the alternative condition is to only do the memcpy if num_bytes != 0. I don't think that provides extra protection over detecting the end of the array. -- To view, visit http://gerrit.cloudera.org:8080/20187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84645271101b4bd594dd25929924a3549c223244 Gerrit-Change-Number: 20187 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Jul 2023 22:30:34 +0000 Gerrit-HasComments: Yes
