Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20192 )
Change subject: IMPALA-12267: DMLs/DDLs can hang as a result of catalogd restart ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/20192/1/be/src/service/impala-server.cc@382 PS1, Line 382: 5 > Ah, you are right. We still need the timeout in case there are no further c It sounds good. There are still some points in the relation of the timeout and max number of iterations that should be decided: - should the limit on the max number of iterations only apply if a timeout is set OR should it be independent? - should the max number of iterations be a fixed number or another startup flag? If the limit on the number of iterations is unconditional, we also change behaviour in situations other than the one described in IMPALA-12267, which is not necessarily a problem but we should be aware of it. http://gerrit.cloudera.org:8080/#/c/20192/3/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/20192/3/tests/common/impala_test_suite.py@477 PS3, Line 477: def get_logs(self): > Can we use assert_impalad_log_contains directly? You're right, I'll update it in the next patch. -- To view, visit http://gerrit.cloudera.org:8080/20192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib71bec8f67f80b0bdfe0a6cc46a16ef624163d8b Gerrit-Change-Number: 20192 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Jul 2023 11:28:16 +0000 Gerrit-HasComments: Yes
