Michael Smith has uploaded this change for review. (
http://gerrit.cloudera.org:8080/20266
Change subject: IMPALA-12315: Remove codegen inline hint
......................................................................
IMPALA-12315: Remove codegen inline hint
Remove LLVM initialization options that effectively told LLVM to treat
all functions as having the inline hint while optimizing. This was
originally evaluated with LLVM 3.3, and performs differently with LLVM
5.
Shows a small improvement in our performance tests:
+----------+-----------------------+---------+------------+------------+----------------+
| Workload | File Format | Avg (s) | Delta(Avg) | GeoMean(s) |
Delta(GeoMean) |
+----------+-----------------------+---------+------------+------------+----------------+
| TPCH(42) | parquet / none / none | 3.39 | -0.22% | 2.54 | -0.41%
|
+----------+-----------------------+---------+------------+------------+----------------+
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| Workload | Query | File Format | Avg(s) | Base Avg(s) |
Delta(Avg) | StdDev(%) | Base StdDev(%) | Iters | Median Diff(%) | MW Zval |
Tval |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
| TPCH(42) | TPCH-Q8 | parquet / none / none | 3.84 | 3.82 | +0.53%
| 1.39% | 1.33% | 50 | +0.22% | 1.70 | 1.94 |
| TPCH(42) | TPCH-Q21 | parquet / none / none | 13.53 | 13.48 | +0.35%
| 0.45% | 0.56% | 50 | +0.37% | 3.30 | 3.41 |
| TPCH(42) | TPCH-Q14 | parquet / none / none | 1.71 | 1.70 | +0.55%
| 2.13% | 1.90% | 50 | +0.04% | 0.76 | 1.37 |
| TPCH(42) | TPCH-Q2 | parquet / none / none | 1.15 | 1.15 | +0.50%
| 2.49% | 2.08% | 50 | +0.08% | 0.91 | 1.08 |
| TPCH(42) | TPCH-Q3 | parquet / none / none | 6.59 | 6.57 | +0.34%
| 0.70% | 1.05% | 50 | +0.08% | 1.60 | 1.89 |
| TPCH(42) | TPCH-Q17 | parquet / none / none | 1.94 | 1.94 | +0.22%
| 2.09% | 1.77% | 50 | +0.03% | 0.52 | 0.56 |
| TPCH(42) | TPCH-Q6 | parquet / none / none | 0.81 | 0.81 | +0.12%
| 1.24% | 0.91% | 50 | -0.00% | -0.17 | 0.53 |
| TPCH(42) | TPCH-Q15 | parquet / none / none | 2.61 | 2.61 | -0.07%
| 1.27% | 1.49% | 50 | -0.02% | -0.29 | -0.24 |
| TPCH(42) | TPCH-Q1 | parquet / none / none | 3.09 | 3.10 | -0.17%
| 1.41% | 1.55% | 50 | -0.01% | -0.10 | -0.58 |
| TPCH(42) | TPCH-Q18 | parquet / none / none | 5.06 | 5.07 | -0.28%
| 2.15% | 2.73% | 50 | -0.01% | -0.14 | -0.58 |
| TPCH(42) | TPCH-Q20 | parquet / none / none | 1.98 | 1.99 | -0.27%
| 1.57% | 1.49% | 50 | -0.06% | -0.78 | -0.90 |
| TPCH(42) | TPCH-Q4 | parquet / none / none | 1.81 | 1.82 | -0.47%
| 1.96% | 2.15% | 50 | -0.03% | -0.83 | -1.15 |
| TPCH(42) | TPCH-Q5 | parquet / none / none | 2.34 | 2.35 | -0.48%
| 1.49% | 1.44% | 50 | -0.13% | -2.12 | -1.63 |
| TPCH(42) | TPCH-Q13 | parquet / none / none | 6.31 | 6.34 | -0.59%
| 4.12% | 4.51% | 50 | -0.10% | -0.91 | -0.68 |
| TPCH(42) | TPCH-Q9 | parquet / none / none | 8.76 | 8.78 | -0.24%
| 1.34% | 0.92% | 50 | -0.52% | -1.99 | -1.04 |
| TPCH(42) | TPCH-Q22 | parquet / none / none | 1.63 | 1.64 | -0.68%
| 2.27% | 2.62% | 50 | -0.12% | -1.06 | -1.39 |
| TPCH(42) | TPCH-Q7 | parquet / none / none | 2.78 | 2.80 | -0.66%
| 1.58% | 1.69% | 50 | -0.41% | -2.14 | -2.01 |
| TPCH(42) | TPCH-Q19 | parquet / none / none | 2.03 | 2.04 | -0.93%
| 1.78% | 1.54% | 50 | -0.23% | -3.26 | -2.82 |
| TPCH(42) | TPCH-Q12 | parquet / none / none | 1.67 | 1.69 | -1.25%
| 1.94% | 1.66% | 50 | -0.25% | -2.98 | -3.48 |
| TPCH(42) | TPCH-Q16 | parquet / none / none | 1.11 | 1.12 | -1.34%
| 2.69% | 2.45% | 50 | -0.19% | -1.79 | -2.62 |
| TPCH(42) | TPCH-Q11 | parquet / none / none | 0.85 | 0.87 | -1.82%
| 3.73% | 3.84% | 50 | -0.59% | -2.53 | -2.42 |
| TPCH(42) | TPCH-Q10 | parquet / none / none | 2.87 | 2.94 | -2.24%
| 1.47% | 2.58% | 50 | -1.79% | -5.15 | -5.37 |
+----------+----------+-----------------------+--------+-------------+------------+-----------+----------------+-------+----------------+---------+-------+
The change actually seems to be more sizable when combined with
IMPALA-12314, where we see Delta(GeoMean) go from -2.45% to -3.49%.
Change-Id: I99721ed102dc8007f41f5a0e78f95eabbc962b46
---
M be/src/codegen/llvm-codegen.cc
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/66/20266/1
--
To view, visit http://gerrit.cloudera.org:8080/20266
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99721ed102dc8007f41f5a0e78f95eabbc962b46
Gerrit-Change-Number: 20266
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <[email protected]>
