Gabor Kaszab has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20274 )

Change subject: IMPALA-12319: Fix NullPointerException in 
UnnestExpr.isBoundByTupleIds()
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test:

http://gerrit.cloudera.org:8080/#/c/20274/2/testdata/workloads/functional-planner/queries/PlannerTest/zipping-unnest.test@296
PS2, Line 296: UNNEST()
It's strange the parameter for unnest is not visible in the output. Having 
multiple unnests in the query would make it ambiguous for the reader which one 
we refer to here.



--
To view, visit http://gerrit.cloudera.org:8080/20274
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I43e1ef0467edfb8a4a23047a439426053c93ad72
Gerrit-Change-Number: 20274
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Fri, 28 Jul 2023 12:57:52 +0000
Gerrit-HasComments: Yes

Reply via email to