Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20276 )
Change subject: IMPALA-12321: Fix the race condition when updating active catalogd ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20276/2/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/20276/2/be/src/runtime/exec-env.cc@671 PS2, Line 671: if (is_registration_reply) { > Defined a new class ActiveCatalogVersionChecker. This will come in a later patch I think? http://gerrit.cloudera.org:8080/#/c/20276/2/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/20276/2/tests/custom_cluster/test_catalogd_ha.py@366 PS2, Line 366: assert(catalogd_service_1.get_metric_value("catalog-server.active-status") > If two boolean variables are not equal, one equals false and another equals ah OK! -- To view, visit http://gerrit.cloudera.org:8080/20276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie49947e563d43c59bdd476b28c35be69848ae12a Gerrit-Change-Number: 20276 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 28 Jul 2023 16:49:15 +0000 Gerrit-HasComments: Yes
