Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19506 )
Change subject: IMPALA-11924: Cap runtime filter NDV with build key NDV ...................................................................... IMPALA-11924: Cap runtime filter NDV with build key NDV Before this patch, the NDV used for bloom filter sizing was based only on the cardinality of the build side. This is ok for FK/PK joins but can highly overestimate NDV if the build key column's NDV is smaller than the number of rows. This change takes the minimum of NDV (not changed by selectiveness) and cardinality (reduced by selectiveness). Testing: - Adjust test_bloom_filters and test_row_filters, raising the NDV of the test case such that the assertion is maintained. - Add 8KB bloom filter test case in test_bloom_filters. Change-Id: Idaa46789663cb2e6d29f518757d89c85ff8e4d1a Reviewed-on: http://gerrit.cloudera.org:8080/19506 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Michael Smith <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java M testdata/workloads/functional-query/queries/QueryTest/bloom_filters.test M testdata/workloads/functional-query/queries/QueryTest/runtime_row_filters.test 3 files changed, 56 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/19506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Idaa46789663cb2e6d29f518757d89c85ff8e4d1a Gerrit-Change-Number: 19506 Gerrit-PatchSet: 10 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
