Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20110 )
Change subject: IMPALA-11901: Support COPY TESTCASE in local catalog mode ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/20110/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20110/4//COMMIT_MSG@10 PS4, Line 10: on > Nit: "on the" Done http://gerrit.cloudera.org:8080/#/c/20110/4//COMMIT_MSG@19 PS4, Line 19: as > Nit: "as" Done http://gerrit.cloudera.org:8080/#/c/20110/4//COMMIT_MSG@27 PS4, Line 27: grained > Nit: "grained" Done http://gerrit.cloudera.org:8080/#/c/20110/4//COMMIT_MSG@33 PS4, Line 33: importing > Nit: "importing" Done http://gerrit.cloudera.org:8080/#/c/20110/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java File fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java: http://gerrit.cloudera.org:8080/#/c/20110/4/fe/src/main/java/org/apache/impala/catalog/FeCatalogUtils.java@443 PS4, Line 443: res.setTable_type(TTableType.VIEW); > Should we have an else block which throws so we can find missing (possibly Done http://gerrit.cloudera.org:8080/#/c/20110/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/20110/4/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@330 PS4, Line 330: private THdfsTable toTHdfsTable(Set<Long> referencedPartitions, ThriftObjectType type) { > Could be private? Done http://gerrit.cloudera.org:8080/#/c/20110/4/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/20110/4/tests/metadata/test_testcase_builder.py@57 PS4, Line 57: tmp_path = get_fs_path("/tmp") > I think now that the testcase includes a table, this will cover the case th Yes, the dockerised test will run this in local catalog mode, e.g. https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/7725/testReport/metadata.test_testcase_builder/ -- To view, visit http://gerrit.cloudera.org:8080/20110 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02c1c76d7af15f28bdbc8d98d92a1553570e9e27 Gerrit-Change-Number: 20110 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 02 Aug 2023 01:58:58 +0000 Gerrit-HasComments: Yes
