Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20295 )
Change subject: IMPALA-12327: Iceberg V2 operator wrong results in PARTITIONED mode ...................................................................... Patch Set 6: (1 comment) Thanks for the comment! http://gerrit.cloudera.org:8080/#/c/20295/5/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/20295/5/be/src/exec/iceberg-delete-node.cc@332 PS5, Line 332: s = false > Maybe we could rename this guy to next_probe_pos, for better readability. Yeah, it's not too likely to hit an int64 overflow here, but fixed it anyway. Clang's UB sanitizer is certainly capable of catching all kinds of overflows, but I'm unsure if we configure every checks. -- To view, visit http://gerrit.cloudera.org:8080/20295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib89a53e812af8c3b8ec5bc27bca0a50dcac5d924 Gerrit-Change-Number: 20295 Gerrit-PatchSet: 6 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Aug 2023 12:22:55 +0000 Gerrit-HasComments: Yes
