Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20272 )
Change subject: IMPALA-12311: Remove extra newlines in the updated golden file ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patch set 2 looks good to me. Thanks for fixing it! http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py File tests/util/test_file_parser.py: http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py@298 PS1, Line 298: """ > Thanks for checking this Riza! Done http://gerrit.cloudera.org:8080/#/c/20272/1/tests/util/test_file_parser.py@327 PS1, Line 327: if section_name == 'QUERY > Looks like the real culprit is here. strip() should be at the end of line 3 Done -- To view, visit http://gerrit.cloudera.org:8080/20272 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic7668a437267bd76afecba8f87ead32d82580414 Gerrit-Change-Number: 20272 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 00:47:07 +0000 Gerrit-HasComments: Yes
