Gergely Farkas has posted comments on this change. ( http://gerrit.cloudera.org:8080/20301 )
Change subject: IMPALA-12328: New option for impala-shell to send "auth" header in thrift http request ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/20301/10/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/20301/10/be/src/transport/THttpServer.cpp@150 PS10, Line 150: && THRIFT_strncasecmp(header, TRANSFER_ENCODING, sz) == 0) { > Based on my reading of the docs and some experimentation with code, we shou Unfortunately, when parsing the following header "Transfer-Encoding-the: fake", the condition that does not use the 'sz' variable will be true, because the first 17 characters will match: THRIFT_strncasecmp(header, TRANSFER_ENCODING, strlen(TRANSFER_ENCODING)) == 0 -- To view, visit http://gerrit.cloudera.org:8080/20301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754639cfe3eab0016d09f71ded4821caa357bf87 Gerrit-Change-Number: 20301 Gerrit-PatchSet: 10 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Aug 2023 20:03:46 +0000 Gerrit-HasComments: Yes
