Daniel Becker has uploaded a new patch set (#3). (
http://gerrit.cloudera.org:8080/20304 )
Change subject: IMPALA-12306: (Part 1) Make codegen cache tests with symbol
emitter more robust
......................................................................
IMPALA-12306: (Part 1) Make codegen cache tests with symbol emitter more robust
The codegen cache tests that include having a symbol emitter (previously
TestCodegenCache.{test_codegen_cache_with_asm_module_dir,test_codegen_cache_with_perf_map})
introduced by IMPALA-12260 were added to ensure we don't produce a
use-after-free.
There are two problems with these tests:
1. Setting the codegen cache size correctly in the tests has proved to
be difficult because new commits and different build types (debug
vs. release) have a huge effect on what sizes are appropriate. We
have had many build failures because of this.
2. Use-after-free is undefined behaviour and does not guarantee a
crash but the tests rely on the crash to catch the bug described in
IMPALA-12260.
This commit solves the first problem. We use the
'--codegen_cache_entry_bytes_charge_overhead' startup flag to
artificially assign a higher size (memory charge) to the cache entries,
compared to which the real size, and therefore also changes in the real
size, are insignificant.
Change-Id: If801ae6d3d9f5286ed886b1d06c37a32bc1d2c54
---
M be/src/codegen/llvm-codegen-cache.cc
M tests/custom_cluster/test_codegen_cache.py
2 files changed, 36 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/20304/3
--
To view, visit http://gerrit.cloudera.org:8080/20304
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If801ae6d3d9f5286ed886b1d06c37a32bc1d2c54
Gerrit-Change-Number: 20304
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
