Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20294 )
Change subject: IMPALA-12288: Add BUILD_WITH_NO_TESTS option to remove test targets ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20294/5/testdata/bin/copy-udfs-udas.sh File testdata/bin/copy-udfs-udas.sh: http://gerrit.cloudera.org:8080/#/c/20294/5/testdata/bin/copy-udfs-udas.sh@58 PS5, Line 58: cd "${IMPALA_HOME}/java/test-hive-udfs" > optional: Can we skip this when we are building Impala without the 'notests It's truly a bit tricky to set the CMAKE option again like this. I updated 'buildall.sh' in the newest patch set, now the 'BUILD_WITH_NO_TESTS' is set ON only when '-notests' and 'package' flags are used at the same time. So that the previous test workflow will not be impacted. -- To view, visit http://gerrit.cloudera.org:8080/20294 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I575ce76176c9f6a05fd2db0f420ebe6926d0272a Gerrit-Change-Number: 20294 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Thu, 10 Aug 2023 12:31:00 +0000 Gerrit-HasComments: Yes
