Gergely Farkas has posted comments on this change. ( http://gerrit.cloudera.org:8080/20301 )
Change subject: IMPALA-12341: Fix http header parsing issue in thrift http server ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/20301/12/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/20301/12/be/src/transport/THttpServer.h@162 PS12, Line 162: static const std::string HEADER_SAML2_TOKEN_RESPONSE_PORT; > Not sure here, but prefixing with HEADER_ as the constants above would be m Good point! I'll change the names to be more consistent. http://gerrit.cloudera.org:8080/#/c/20301/12/be/src/transport/THttpServer.cpp File be/src/transport/THttpServer.cpp: http://gerrit.cloudera.org:8080/#/c/20301/12/be/src/transport/THttpServer.cpp@132 PS12, Line 132: inline const bool Matc > We should simply use a function here IMO - THRIFT_strncasecmp is created wi Okay, I'll introduce a new inline function instead of this. -- To view, visit http://gerrit.cloudera.org:8080/20301 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I754639cfe3eab0016d09f71ded4821caa357bf87 Gerrit-Change-Number: 20301 Gerrit-PatchSet: 13 Gerrit-Owner: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gergely Farkas <gfar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Aug 2023 08:45:46 +0000 Gerrit-HasComments: Yes
