Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20372 )

Change subject: WIP IMPALA-12156: Support High Availability for Statestore
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/20372/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

http://gerrit.cloudera.org:8080/#/c/20372/1/be/src/common/global-flags.cc@410
PS1, Line 410: DEFINE_int64(update_statestored_rpc_resend_interval_ms, 100, 
"(Advanced) Interval (in ms) "
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/20372/1/be/src/statestore/statestore.cc
File be/src/statestore/statestore.cc:

http://gerrit.cloudera.org:8080/#/c/20372/1/be/src/statestore/statestore.cc@1705
PS1, Line 1705:   
RETURN_IF_ERROR(Thread::Create("statestore-update-satestored", 
"update-statestored-thread",
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/20372/1/be/src/statestore/statestore.cc@1742
PS1, Line 1742:                 DebugAction(FLAGS_debug_actions, 
"STATESTORE_HA_HANDSHAKE_FIRST_ATTEMPT") :
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/20372/1/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

http://gerrit.cloudera.org:8080/#/c/20372/1/bin/start-impala-cluster.py@634
PS1, Line 634:
flake8: E241 multiple spaces after ','



--
To view, visit http://gerrit.cloudera.org:8080/20372
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd2c814bbad5c04c1d50c2edaa5b910c82a6fd87
Gerrit-Change-Number: 20372
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Aug 2023 19:59:46 +0000
Gerrit-HasComments: Yes

Reply via email to