Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20306 )
Change subject: IMPALA-12228: Simulate the failure of an iceberg transaction. ...................................................................... Patch Set 1: (1 comment) Thanks for the review http://gerrit.cloudera.org:8080/#/c/20306/1/fe/src/main/java/org/apache/impala/util/DebugUtils.java File fe/src/main/java/org/apache/impala/util/DebugUtils.java: http://gerrit.cloudera.org:8080/#/c/20306/1/fe/src/main/java/org/apache/impala/util/DebugUtils.java@166 PS1, Line 166: : > How about assuming that exceptionClazz is a fully qualified Java class, and That was my first idea for implementation. I was thinking every interesting exception would have a simple constructor with a single string argument that I could invoke via reflection. Then the fault injection could be dynamic as you suggest. But when I came to code it, I found the signature of the constructor for CommitException is public CommitFailedException(String message, Object... args) and this did not fit my expectations for a simple constructor, and the reflection code I would need is not particularly likely to be reusablle by future exceptions. Rather than requiring future implementers to write more reflection code, I decided it was easiest to just explicitly create the exception(s) here. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/20306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafdacc3377a0a946ead9331ba6a63a1fbb11f0eb Gerrit-Change-Number: 20306 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Aug 2023 21:22:50 +0000 Gerrit-HasComments: Yes
