Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20377 )
Change subject: IMPALA-12385: Enable Periodic metrics by default ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20377/1/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/20377/1/be/src/util/runtime-profile.cc@2023 PS1, Line 2023: TimeSeriesCounter* counter = pool_->Add(new SamplingTimeSeriesCounter(name, unit, fn, FLAGS_periodic_counter_update_period_ms)); line too long (130 > 90) http://gerrit.cloudera.org:8080/#/c/20377/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/20377/1/tests/query_test/test_observability.py@532 PS1, Line 532: r flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/20377/1/tests/query_test/test_observability.py@532 PS1, Line 532: """Tests that the query profile does not contain resource usage metrics line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20377 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8e5cbfd4b324081158574ceb8f4b3a062a69fd1 Gerrit-Change-Number: 20377 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Fri, 18 Aug 2023 14:35:07 +0000 Gerrit-HasComments: Yes
