Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 )
Change subject: IMPALA-11996: Scanner change for Iceberg metadtata querying ...................................................................... Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h File be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h: http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.h@115 PS3, Line 115: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc File be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc: http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@39 PS3, Line 39: iceberg_api_scan_timer_(ADD_TIMER(scan_node_->runtime_profile(), line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@186 PS3, Line 186: jobject column_field = env->CallObjectMethod(columns, list_get_, slot_desc->col_pos()); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@245 PS3, Line 245: RETURN_IF_ERROR(MaterializeNextRow(env, struct_like_row, tuple, state, row_batch->tuple_data_pool())); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@249 PS3, Line 249: if (ExecNode::EvalConjuncts(scan_node_->conjunct_evals().data(), scan_node_->conjunct_evals().size(), tuple_row)) { line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@255 PS3, Line 255: Tuple::ClearNullBits(tuple, tuple_desc_->null_bytes_offset(), tuple_desc_->num_null_bytes()); line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@263 PS3, Line 263: Status IcebergMetadataTableScanner::MaterializeNextRow(JNIEnv* env, jobject struct_like_row, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/exec/iceberg-metadata/iceberg-metadata-table-scanner.cc@280 PS3, Line 280: RETURN_IF_ERROR(ReadStringValue(env, slot_desc, struct_like_row, tuple, tuple_data_pool)); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20010/3/be/src/service/frontend.cc@110 PS3, Line 110: {"getCatalogTable", "([B)Lorg/apache/impala/catalog/FeTable;", &get_catalog_table_id_}, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java: http://gerrit.cloudera.org:8080/#/c/20010/3/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java@40 PS3, Line 40: private final static Logger LOG = LoggerFactory.getLogger(IcebergMetadataScanNode.class); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20010/3/fe/src/main/java/org/apache/impala/planner/IcebergMetadataScanNode.java@45 PS3, Line 45: protected IcebergMetadataScanNode(PlanNodeId id, List<Expr> conjuncts, TableRef tblRef) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e943cecd77f5ef7af7cd07e2b596f2c5b4331e7 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 3 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Aug 2023 14:43:25 +0000 Gerrit-HasComments: Yes
