Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20368 )
Change subject: IMPALA-12024: Add catalog profile for createTable ...................................................................... Patch Set 3: (12 comments) I think it is important to make the event label self explanatory and as clear as possible. Otherwise, an explanation should be documented somewhere for each label. Some general comments: - Replace HMS with Metastore for consistency. - Consider turning some duplicated event label into string constant. - Clarify the source of event. Is it Metastore vs CatalogD vs Filesystem vs other service (like Kudu master). http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3523 PS3, Line 3523: catalogTimeline.markEvent("Created Metastore table"); : } else { : catalogTimeline.markEvent("Found table exists"); Maybe reorganize this to 2 things: existence check and new table creation: - Checked table existence in Metastore: xx ms - Created table in Metastore: xx ms The first one is always printed. The second one only show up in new table creation. http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3552 PS3, Line 3552: Created catalog table nit: "Cached table in catalogd"? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3610 PS3, Line 3610: Created Metastore table nit: "Created table in Metastore"? This is referred twice in chis class. Should this be a constant instead? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3627 PS3, Line 3627: HMS nit: "Fetched table from Metastore"? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3656 PS3, Line 3656: Created catalog table nit: "Cached table in catalog"? This is referred twice in chis class. Should this be a constant instead? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3702 PS3, Line 3702: HMS nit: Metastore Is this label intentionally made different from the other "HMS table fetched" at line 3627? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3786 PS3, Line 3786: Created iceberg table nit: created in where? HMS, filesystem, or CatalogD cache? Why iceberg has its own specific label? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3827 PS3, Line 3827: Created Metastore table nit: dulicated String. Change to constant? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3834 PS3, Line 3834: Found table exists nit: dulicated String. Change to constant? Found in CatalogD or Metastore? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@102 PS3, Line 102: Checked table exists nit: Checked table existence Exist in where? Kudu master, HMS, or CatalogD? http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@342 PS3, Line 342: Checked table exists nit: Checked table existence http://gerrit.cloudera.org:8080/#/c/20368/3/fe/src/main/java/org/apache/impala/service/KuduCatalogOpExecutor.java@369 PS3, Line 369: cols nit: columns -- To view, visit http://gerrit.cloudera.org:8080/20368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ebf591625e71391a5b23f56ddca8f0ae97b1efa Gerrit-Change-Number: 20368 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Aug 2023 17:18:27 +0000 Gerrit-HasComments: Yes
