Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20263 )
Change subject: IMPALA-12362: Improve Linux packaging support. ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh File package/bin/impala.sh: http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh@22 PS5, Line 22: # User can custom flags in '../conf/[impalad_flags...]', or override them in commandline arguments when needed(e.g. multiple instance). line too long (135 > 90) http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh@27 PS5, Line 27: # Please modify core-site.xml, hdfs-site.xml, hive-site.xml, etc. in conf based on the cluster. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh@68 PS5, Line 68: echo "Already stopped: ${service} is not running with PID $pid. Removed stale file '${service_pidfile}'" line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh@83 PS5, Line 83: echo "HADOOP_HOME not set. Using hadoop native libs in '${HADOOP_LIB_DIR:=${IMPALA_HOME}/lib/native}'" line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/20263/5/package/bin/impala.sh@88 PS5, Line 88: export LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:${IMPALA_HOME}/lib/native:${LIB_JVM_DIR}:${LIB_JSIG_DIR}" line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/20263/5/package/conf/impala-env.sh File package/conf/impala-env.sh: http://gerrit.cloudera.org:8080/#/c/20263/5/package/conf/impala-env.sh@22 PS5, Line 22: # like ': ${FOO:="bar"}', or 'export FOO=${FOO:-"bar"}' when the variable need to be exported. line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3914dcda69f81a735cdf70d76c59fa09454777b Gerrit-Change-Number: 20263 Gerrit-PatchSet: 5 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Aug 2023 08:38:43 +0000 Gerrit-HasComments: Yes
