Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20396 )
Change subject: IMPALA-12393: Fix inconsistent hash for TimestampValue in DictEncoder ...................................................................... Patch Set 2: With subsequent investigation, it looks like this is a test-only issue, so I updated the commit message to make that clear. I also double-checked that performance isn't worse with TimestampValue::Hash(). -- To view, visit http://gerrit.cloudera.org:8080/20396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iad86e9b0f645311c3389cf2804dcc1a346ff10a9 Gerrit-Change-Number: 20396 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Aug 2023 00:44:02 +0000 Gerrit-HasComments: No
