ttttttz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20358 )

Change subject: IMPALA-10856: Show client hosts and connections in the web UI
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 4: Code-Review+1
>
> (1 comment)
Yes, this ambiguity should be avoided.

http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h
File be/src/service/impala-server.h:

http://gerrit.cloudera.org:8080/#/c/20358/4/be/src/service/impala-server.h@525
PS4, Line 525: Merge
> nit: "Merge" sounds like modifying something but we just retrieving the lis
Ack



--
To view, visit http://gerrit.cloudera.org:8080/20358
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89015b00e1b97a1836eeca205b2c80b32300227
Gerrit-Change-Number: 20358
Gerrit-PatchSet: 5
Gerrit-Owner: ttttttz <2433038...@qq.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: ttttttz <2433038...@qq.com>
Gerrit-Comment-Date: Wed, 23 Aug 2023 09:48:31 +0000
Gerrit-HasComments: Yes

Reply via email to