Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/20380 )
Change subject: [tools] Add Dev Container support for Impala development. ...................................................................... Patch Set 5: > Patch Set 3: Code-Review+2 > > LGTM. Welcome back to the community, Fredy! We really miss you. > > BTW, it'd be nice if you could also update the wiki about this: > https://cwiki.apache.org/confluence/display/IMPALA/Impala+Development+Environment+inside+Docker Thanks Quanlong for the LGTM :) Done. Updated the wiki. -- To view, visit http://gerrit.cloudera.org:8080/20380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50508a09710641ec2a299b001fef3e7fefb0b7d5 Gerrit-Change-Number: 20380 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fre...@apache.org> Gerrit-Reviewer: Fredy Wijaya <fre...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 23 Aug 2023 16:00:30 +0000 Gerrit-HasComments: No