Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20344 )
Change subject: IMPALA-10120: Add required fields for TGetInfoResp when error. ...................................................................... Patch Set 2: (1 comment) Thanks for digging into this! Could you add a test so it won't break in the future? E.g. running the following command beeline -u "jdbc:hive2://localhost:21050/default;auth=noSasl" -e queries Queries can be "SHOW TABLES" plus some SELECT/CREATE/INSERT/DROP statements. We can have a test like tests/shell/test_shell_commandline.py, e.g. test_beeline.py. Using codes similar to https://github.com/apache/impala/blob/4b62812995ce380f2dca038bac017432c6c5d14f/tests/common/impala_test_suite.py#L1030-L1045 http://gerrit.cloudera.org:8080/#/c/20344/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/20344/2/be/src/service/impala-hs2-server.cc@479 PS2, Line 479: return_val.infoValue.__set_stringValue(""); Do we need this for all usages of HS2_RETURN_ERROR() ? -- To view, visit http://gerrit.cloudera.org:8080/20344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib42bb82735fb4a8e6911b6a19adb8bd84973300b Gerrit-Change-Number: 20344 Gerrit-PatchSet: 2 Gerrit-Owner: Xiang Yang <yx91...@126.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 24 Aug 2023 08:52:44 +0000 Gerrit-HasComments: Yes
