Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-cache.h File be/src/codegen/llvm-codegen-cache.h: http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-cache.h@166 PS2, Line 166: void Init() { memset((uint8_t*)this, 0, sizeof(CodeGenCacheEntry)); } Not relevant to this change but wouldn't it be better to call Reset() here instead of memset()? Afaik 'nullptr' is not guaranteed to be represented by the 0 value. http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen-test.cc@594 PS2, Line 594: NULL Nit: could be 'nullptr'. http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/2/be/src/codegen/llvm-codegen.cc@1448 PS2, Line 1448: Nit: unneeded space. http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift@845 PS2, Line 845: O1, Os, O2, or O3 O0 is also a possibility. http://gerrit.cloudera.org:8080/#/c/20399/2/common/thrift/ImpalaService.thrift@846 PS2, Line 846: Defaults to O2. If we ever change the default value we'll probably forget this comment. The default value can be seen in common/thrift/Query.thrift, so we don't need to write it here. -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 24 Aug 2023 12:03:20 +0000 Gerrit-HasComments: Yes
