Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20397 )
Change subject: IMPALA-12387: PartialUpdates is misleading for LOCAL filter ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20397/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test File testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test: http://gerrit.cloudera.org:8080/#/c/20397/1/testdata/workloads/functional-query/queries/QueryTest/in_list_filters.test@181 PS1, Line 181: LOCAL > This is ok to me. Just curious, is it doable to get the stats if the fragme For global filter aggregating in coordinator, I think column "Pending (Expected)" is quite representative to show how many total contributors for a filter. For more granular tracing, we'll need to add new field to do the counting at least at PublishFilterParamsPB. Not sure if its worth to hack since it will be only interesting for filters that quickly become ALL_TRUE / ALL_FALSE. -- To view, visit http://gerrit.cloudera.org:8080/20397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56078a458799671246ff90b831e5ecebd04a78e8 Gerrit-Change-Number: 20397 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 24 Aug 2023 22:59:57 +0000 Gerrit-HasComments: Yes
