Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20399 )
Change subject: IMPALA-5081: Add codegen_opt_level query option ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen-test.cc File be/src/codegen/llvm-codegen-test.cc: http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen-test.cc@679 PS3, Line 679: > Nit: use. Done http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen-test.cc@694 PS3, Line 694: n > Instead of hard-coding this value, we could extract the opt levels on L673 Done http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen.cc@129 PS3, Line 129: "The IR optimization level for pre-generated code; supports O1, O2, and Os."); > Is O0 removed because it prevents further optimisation? It was an accidental change I reverted, this option is unrelated to the patch. I guess I decided to omit O0 when creating this, just like O3 didn't seem to help. Also Clang O0 is weird and inserts lots of noinline comments, so similar to https://gerrit.cloudera.org/c/20399/3/be/src/codegen/CMakeLists.txt#115 it would almost certainly work poorly. http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen.cc@1340 PS3, Line 1340: COUNTER_SET(num_opt_functions_, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/20399/3/be/src/codegen/llvm-codegen.cc@1343 PS3, Line 1343: } else { > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/20399 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I371f8758b6552263e91a1fbfd9a6e1c28e1fa2bd Gerrit-Change-Number: 20399 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 25 Aug 2023 17:06:25 +0000 Gerrit-HasComments: Yes
