Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18001 )
Change subject: IMPALA-10086: SqlCastException when comparing char with varchar ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/18001/2/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/18001/2/fe/src/main/java/org/apache/impala/analysis/Expr.java@1574 PS2, Line 1574: if (!(((targetType.isWildcardVarchar() || targetType.isWildcardChar()) && type.isVarchar()) || > This condition has lots of parentheses, it is difficult to read. We could e I can try to make this cleaner, and add some more test cases. -- To view, visit http://gerrit.cloudera.org:8080/18001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cd331ae1b6afb778a88080efd38900694539a89 Gerrit-Change-Number: 18001 Gerrit-PatchSet: 2 Gerrit-Owner: Bruno Pusztahazi <bpusztah...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Aug 2023 17:55:14 +0000 Gerrit-HasComments: Yes
