Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20022 )
Change subject: IMPALA-11535: Skip older events in the event processor based on the latestRefreshEventID ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/20022/14/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20022/14/tests/custom_cluster/test_events_custom_configs.py@337 PS14, Line 337: EventProcessorUtils.wait_for_event_processing(self) Can we also verify no table/partitions are refreshed here? We can extract the following pattern into a method to simplify the code: def verify_skipping_hive_stmt_events(stmt): self.run_stmt_in_hive(stmt) self.client.execute("refresh ...") get event metrics EventProcessorUtils.wait_for_event_processing(self) get event metrics and compare them 'stmt' can be multiple statments like 3 INSERTs. -- To view, visit http://gerrit.cloudera.org:8080/20022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0dc5c7396d80616680d8a5805ce80db293b72e1 Gerrit-Change-Number: 20022 Gerrit-PatchSet: 14 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Aug 2023 02:29:58 +0000 Gerrit-HasComments: Yes
