Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20368 )
Change subject: IMPALA-12024: Add catalog profile for createTable ...................................................................... Patch Set 5: Code-Review+2 (1 comment) This looks good to me http://gerrit.cloudera.org:8080/#/c/20368/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20368/5/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3738 PS5, Line 3738: Preconditions.checkState(tableName.isFullyQualified()); > TableName.fromThrift() always return a non-null result: That makes sense -- To view, visit http://gerrit.cloudera.org:8080/20368 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ebf591625e71391a5b23f56ddca8f0ae97b1efa Gerrit-Change-Number: 20368 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 29 Aug 2023 23:44:59 +0000 Gerrit-HasComments: Yes
