Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20420 )
Change subject: IMPALA-12231: Bump GBN to get HMS thrift API changes ...................................................................... Patch Set 7: (4 comments) LGTM. Just have some minor comments on the test. http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@508 PS7, Line 508: # IMPALA-11768 -- Insert partition events should be ignored Could you split this into another test since it's a separated issue? http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@512 PS7, Line 512: "insert into {}.{} partition(year=2023) values (1,2)" This is a new partition. I don't see an INSERT event is generated. Instead, there is only one ADD_PARTITION event. http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@517 PS7, Line 517: assert EventProcessorUtils.get_event_processor_status() == "ACTIVE" Shouldn't we need Impala side changes to catch the InvalidObjectException to make this work? Just afraid this will be flaky. http://gerrit.cloudera.org:8080/#/c/20420/7/tests/custom_cluster/test_events_custom_configs.py@519 PS7, Line 519: nit: two blank lines here. Let's keep one. -- To view, visit http://gerrit.cloudera.org:8080/20420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I117873b628aed3e24280f9fcd79643f918c8d5f3 Gerrit-Change-Number: 20420 Gerrit-PatchSet: 7 Gerrit-Owner: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 30 Aug 2023 01:46:11 +0000 Gerrit-HasComments: Yes
