Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 )
Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@906 PS1, Line 906: TestValue(operand + ' ' + operators[i] + StrCat(" " + operand), TYPE_BOOLEAN, is_equal); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@4997 PS1, Line 4997: TestValue(StrCat("length(base64encode('", as_octal, "')) > length('", as_octal, "')"), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@4999 PS1, Line 4999: TestValue(StrCat("base64decode(base64encode('", as_octal + "')) = '", as_octal, "'"), line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6050 PS1, Line 6050: TestStringValue(StrCat("conv(", q, lexical_cast<string>(numeric_limits<int64_t>::max()) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6052 PS1, Line 6052: TestStringValue(StrCat("conv(", q, lexical_cast<string>(numeric_limits<int64_t>::max()) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6054 PS1, Line 6054: TestStringValue(StrCat("conv(", q, lexical_cast<string>(numeric_limits<int64_t>::min()+1) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6056 PS1, Line 6056: TestStringValue(StrCat("conv(", q, lexical_cast<string>(numeric_limits<int64_t>::min()+1) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6946 PS1, Line 6946: TestIsNull(StrCat(unit, "_add(years_add(cast('9999-12-31 23:59:59' as timestamp), 1), " line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6948 PS1, Line 6948: TestIsNull(StrCat(unit, "_sub(cast('1400-01-01 00:00:00' as timestamp), ", max_int, ")"), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/20445/1/be/src/exprs/expr-test.cc@6950 PS1, Line 6950: TestIsNull(StrCat(unit, "_add(years_add(cast('9999-12-31 23:59:59' as timestamp), 1), " line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <gaurav1...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Aug 2023 20:14:33 +0000 Gerrit-HasComments: Yes
