Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface. ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/1/be/src/service/frontend.cc@88 PS1, Line 88: "the JniFrontend class included in the repository is used as the frontend interface. This " line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py File tests/custom_cluster/test_external_planner.py: http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@21 PS1, Line 21: import shutil flake8: F401 'shutil' imported but unused http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42 PS1, Line 42: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@42 PS1, Line 42: assert setup_client.execute("select 2").data == ['2'] line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44 PS1, Line 44: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/20459/1/tests/custom_cluster/test_external_planner.py@44 PS1, Line 44: assert setup_client.execute("select 1").data == ['42'] line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 06 Sep 2023 13:51:46 +0000 Gerrit-HasComments: Yes
