Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20366 )
Change subject: IMPALA-12357: Skip scheduling bloom filter from full-build scan ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@862 PS13, Line 862: is nit: are http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@881 PS13, Line 881: hasHardEstimates_ I don't get it - why do we have access to this protected member? http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/20366/13/fe/src/main/java/org/apache/impala/planner/ScanNode.java@95 PS13, Line 95: hasHardEstimates_ Maybe one more thing that could be checked is that there is only one tuple so there are no collection types involved. I am not sure that this is really needed, but generally stats like row size can be off if there are collections as we have no stats from HMS for collection sizes. http://gerrit.cloudera.org:8080/#/c/20366/13/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test File testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test: http://gerrit.cloudera.org:8080/#/c/20366/13/testdata/workloads/functional-planner/queries/PlannerTest/bloom-filter-assignment.test@553 PS13, Line 553: hosts=1 I see that the host number is always 1 in this file - does that mean that these are all single node plans? Or we check the plan before the distributed plan phase? I don't get it completely how the tree traversal passes through exchange nodes, so I am a bit worried about not testing plans with exchange nodes. -- To view, visit http://gerrit.cloudera.org:8080/20366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I494533bc06da84e606cbd1ae1619083333089a5e Gerrit-Change-Number: 20366 Gerrit-PatchSet: 13 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: David Rorke <dro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 07 Sep 2023 19:57:40 +0000 Gerrit-HasComments: Yes
