Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20387
to look at the new patch set (#3).
Change subject: IMPALA-12390 (part 1): Enable some clang-tidy performance
related checks
......................................................................
IMPALA-12390 (part 1): Enable some clang-tidy performance related checks
This enables several Clang Tidy performance checks and fixes
the flagged code locations. The specific checks enabled are:
1. performance-faster-string-find
"warning: 'find' called with a string literal consisting of a
single character; consider using the more effective overload
accepting a character"
Fix: Use char literals rather than string literals
2. performance-for-range-copy
"warning: loop variable is copied but only used as const reference;
consider making it a const reference"
Fix: Use const & for some locations of auto
3. performance-implicit-cast-in-loop
"warning: the type of the loop variable '$VAR' is different from
the one returned by the iterator and generates an implicit cast;
you can either change the type to the correct one ('$TYPE' but
'const auto&' is always an option) or remove the reference to make
it explicit that you are creating a new value"
Fix: Use the right type or const auto&
4. performance-inefficient-vector-operation
"warning: 'push_back' is called inside a loop; consider pre-allocating
the vector capacity before the loop"
Fix: Call reserve() on the vector before the loop
5. performance-type-promotion-in-math-fn - not encountered in our code
This disables a few performance checks temporarily to keep the
change a reasonable size.
Testing:
- Ran bin/run_clang_tidy.sh with the new checks
- Ran GVO
Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
---
M .clang-tidy
M be/src/benchmarks/convert-timestamp-benchmark.cc
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog-util.cc
M be/src/codegen/llvm-codegen.cc
M be/src/common/logging.cc
M be/src/exec/hdfs-columnar-scanner.cc
M be/src/exec/parquet/hdfs-parquet-scanner-test.cc
M be/src/exec/parquet/parquet-bool-decoder-test.cc
M be/src/exec/parquet/parquet-page-index-test.cc
M be/src/exprs/aggregate-functions-test.cc
M be/src/exprs/anyval-util.cc
M be/src/exprs/timezone_db.cc
M be/src/rpc/authentication.cc
M be/src/rpc/rpc-mgr.cc
M be/src/runtime/bufferpool/buffer-pool-test.cc
M be/src/runtime/bufferpool/free-list-test.cc
M be/src/runtime/coordinator.cc
M be/src/runtime/dml-exec-state.cc
M be/src/runtime/io/data-cache-test.cc
M be/src/runtime/io/disk-io-mgr-test.cc
M be/src/runtime/io/error-converter.cc
M be/src/runtime/tmp-file-mgr-test.cc
M be/src/runtime/tmp-file-mgr.cc
M be/src/runtime/types.cc
M be/src/runtime/types.h
M be/src/scheduling/admission-controller-test.cc
M be/src/scheduling/admission-controller.cc
M be/src/scheduling/cluster-membership-mgr.cc
M be/src/service/client-request-state.cc
M be/src/service/fe-support.cc
M be/src/service/impala-server.cc
M be/src/statestore/statestore-subscriber.cc
M be/src/udf/uda-test.cc
M be/src/udf_samples/uda-sample-test.cc
M be/src/util/dict-test.cc
M be/src/util/ldap-simple-bind.cc
M be/src/util/mem-info.cc
M be/src/util/rle-test.cc
M be/src/util/runtime-profile.cc
M be/src/util/simple-logger-test.cc
M be/src/util/string-util.cc
M be/src/util/webserver-test.cc
43 files changed, 71 insertions(+), 36 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/20387/3
--
To view, visit http://gerrit.cloudera.org:8080/20387
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d5dfe04ffb4ec6f156e268c31a356651410ce91
Gerrit-Change-Number: 20387
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
