Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20459 )
Change subject: IMPALA-12424: Allow third party JniFrontend interface. ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@87 PS2, Line 87: DEFINE_string(jni_frontend_class, "org/apache/impala/service/JniFrontend", "By default " > They'd need to override this on any impalad and catalogd instances, right? Done http://gerrit.cloudera.org:8080/#/c/20459/2/be/src/service/frontend.cc@89 PS2, Line 89: "This option allows the class to be overridden by a third party module."); > Nit: Should we say something about the specified class being a subclass of Does it have to be though? I think an implementor can reimplement all the methods specified in the JniMethodDescriptor class and then not derive from JniFrontend. But I'll add this as a "preferred usage" which probably makes sense. http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: <module>external-frontend</module> > Since there is no dependency from fe or executor-deps (or anything else tha Done http://gerrit.cloudera.org:8080/#/c/20459/2/java/pom.xml@371 PS2, Line 371: <module>external-frontend</module> > I built this locally and verified that the docker images don't contain it a Done -- To view, visit http://gerrit.cloudera.org:8080/20459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89e677da557b39232847644b6ff17510e2b3c3d5 Gerrit-Change-Number: 20459 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 08 Sep 2023 14:03:50 +0000 Gerrit-HasComments: Yes
