Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20267 )
Change subject: [tools] Simplify local toolchain development ...................................................................... Patch Set 5: (2 comments) Please file a JIRA. This simplifies the case where someone wants to modify the toolchain. It can be checked out to the appropriate hash, and then any future modifications will take effect through buildall.sh. I think this looks good. What this doesn't do is deal with this local toolchain consistently if you switch branches. If the IMPALA_TOOLCHAIN_COMMIT_HASH goes from x to y, the toolchain checkout isn't touched and stays at x. This is a use case we don't currently care about much, so we could do that separately. Heading in that direction gets us closer to Kudu's thirdparty model where it just gets triggered and kept up to date as part of the build. We also have a new toolchain since this upload. http://gerrit.cloudera.org:8080/#/c/20267/5/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/20267/5/buildall.sh@433 PS5, Line 433: cd - To make it explicit, should we use pushd/popd? http://gerrit.cloudera.org:8080/#/c/20267/5/buildall.sh@452 PS5, Line 452: cp $IMPALA_HOME/../hadoopAarch64NativeLibs/lib* $HADOOP_HOME/lib/native/ A theory I have is that this can create problems for a running cluster. If something is running and occasionally accessing these native libraries, this creates a window where they are being overwritten/modified. Not your change, so we can think about this separately. -- To view, visit http://gerrit.cloudera.org:8080/20267 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a9e51b7f54c738d8cc01b32428ac88a344de376 Gerrit-Change-Number: 20267 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Sep 2023 17:28:42 +0000 Gerrit-HasComments: Yes
