Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 )
Change subject: [arm64] remove dependence on sse2neon ...................................................................... Patch Set 6: Code-Review+1 (1 comment) This is looking good to me, a couple minor things Not your change, but if you don't mind, can you also remove the includes of sse-util.h and cpu-util.h from be/src/runtime/string-value.inline.h? I was grepping through to see what code used sse-util.h and found that, and the code hasn't needed those includes for a while. https://github.com/apache/impala/blob/master/be/src/runtime/string-value.inline.h#L25-L26 http://gerrit.cloudera.org:8080/#/c/19954/6/be/src/util/sse-util.h File be/src/util/sse-util.h: http://gerrit.cloudera.org:8080/#/c/19954/6/be/src/util/sse-util.h@179 PS6, Line 179: static inline int POPCNT_popcnt_u64(uint64_t x) { If I understand the code correctly, I think we would also need to change this code in bit-util.h: https://github.com/apache/impala/blob/master/be/src/util/bit-util.h#L151-L163 Right now, it uses PopcountNoHw(x) for aarch64. -- To view, visit http://gerrit.cloudera.org:8080/19954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c78c877ef530fa9f35d36da523ad67ab34e5e7 Gerrit-Change-Number: 19954 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <s...@amazon.com> Gerrit-Reviewer: Anonymous Coward <s...@amazon.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Sep 2023 22:26:45 +0000 Gerrit-HasComments: Yes
