cclive1...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20443 )
Change subject: IMPALA-12402: Make CatalogdMetaProvider's cache concurrency level configurable ...................................................................... Patch Set 4: (2 comments) I have modify the commit message together with the merge conflict http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc@127 PS1, Line 127: "If --use_local_catalog is enabled, configures the local cache's concurrency " > Why introduce a new term (consistency) instead of use concurrency? yes, I will change today. http://gerrit.cloudera.org:8080/#/c/20443/1/be/src/runtime/exec-env.cc@128 PS1, Line 128: "level to avoid lock contention, the default value 4 is consistent with the " > nit: remove space before comma. ok -- To view, visit http://gerrit.cloudera.org:8080/20443 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8e3c10660e371498c2edc1eb8d235b7b8ca170c9 Gerrit-Change-Number: 20443 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <cclive1...@gmail.com> Gerrit-Reviewer: Anonymous Coward <cclive1...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Comment-Date: Wed, 13 Sep 2023 03:46:38 +0000 Gerrit-HasComments: Yes
