Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/20445 )
Change subject: IMPALA-12390 (part 2): Enable some clang-tidy performance related checks ...................................................................... Patch Set 8: (1 comment) This looks good, one small nit then we are good. http://gerrit.cloudera.org:8080/#/c/20445/8/bin/run_clang_tidy.sh File bin/run_clang_tidy.sh: http://gerrit.cloudera.org:8080/#/c/20445/8/bin/run_clang_tidy.sh@62 PS8, Line 62: STRCAT_MESSAGE="Impala-specific note:This can also be fixed using the StrCat() function\ : from be/src/gutil/strings strcat.h)" One small nit: Add a space after "Impala-specific note:" (before "This") and another after "function" before the \ -- To view, visit http://gerrit.cloudera.org:8080/20445 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibad8bd0f12aab92ad874f5a6b9ec922dce7f3190 Gerrit-Change-Number: 20445 Gerrit-PatchSet: 8 Gerrit-Owner: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Sep 2023 21:25:06 +0000 Gerrit-HasComments: Yes
