Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20487 )
Change subject: IMPALA-12399: (addendum) Fixed possible deadloop ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@937 PS2, Line 937: .getNextNotification(msClient.getHiveClient(), eventRequest); I realized that we don't want to filter out any event types here since we are just fetching the latest event and want to get the event time of it. We need to extend getNextNotification() to avoid adding the filter silently. http://gerrit.cloudera.org:8080/#/c/20487/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1052 PS2, Line 1052: } We also need to update lastSyncedEventId_ if 'events' is empty now. -- To view, visit http://gerrit.cloudera.org:8080/20487 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb4b8c3db23d39226f10b33cca4e6a1ab271b925 Gerrit-Change-Number: 20487 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Sep 2023 01:24:06 +0000 Gerrit-HasComments: Yes
