Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20500
Change subject: IMPALA-8675: Remove db/table count metrics from impalad in LocalCatalog mode ...................................................................... IMPALA-8675: Remove db/table count metrics from impalad in LocalCatalog mode In the /metrics webUI, coordinator shows metrics of "catalog.num-databases" and "catalog.num-tables" for its local catalog cache. They are updated at the end of each query execution, via Frontend.getCatalogMetrics(). In LocalCatalog mode, there is no need for every coordinator to have the full list of tables of every database. However, getCatalogMetrics ends up iterating over every DB and fetching these lists (if uncached) in order to provide a count. This introduces unnecessary catalog RPCs at the end of each query execution. When catalogd is slow/hanging in processing such coordinator RPCs, simple queries will also be hanging. This patch removes tracking the db/table count metrics from coordinator side in LocalCatalog mode. They will always be -1. The count isn't particularly relevant – if someone wants to keep track of the size of their catalog they are better off looking at that metric from catalogd. Tests: - test_non_compact_catalog_topic_updates uses these two metrics to detect new catalog updates. Changed it to use "catalog.curr-version" instead. Change-Id: I02a409b7b24577f75d7c439c85bc3491ec7c518c --- M common/thrift/metrics.json M fe/src/main/java/org/apache/impala/service/Frontend.java M tests/custom_cluster/test_compact_catalog_updates.py 3 files changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/20500/1 -- To view, visit http://gerrit.cloudera.org:8080/20500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I02a409b7b24577f75d7c439c85bc3491ec7c518c Gerrit-Change-Number: 20500 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com>
