Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20010 )
Change subject: IMPALA-11996: Scanner change for Iceberg metadata querying ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/20010/6/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.h File be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.h: http://gerrit.cloudera.org:8080/#/c/20010/6/be/src/exec/iceberg-metadata/iceberg-metadata-scan-node.h@121 PS6, Line 121: /// Initializes the metadata table and executes an Iceberg scan through JNI. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/6/be/src/exec/iceberg-metadata/iceberg-row-reader.h File be/src/exec/iceberg-metadata/iceberg-row-reader.h: http://gerrit.cloudera.org:8080/#/c/20010/6/be/src/exec/iceberg-metadata/iceberg-row-reader.h@33 PS6, Line 33: /// rows. It utilizes the provided {Accessor} objects to do this translation and line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/6/be/src/exec/iceberg-metadata/iceberg-row-reader.h@37 PS6, Line 37: IcebergRowReader(const TupleDescriptor* tuple_desc, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/6/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java File fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java: http://gerrit.cloudera.org:8080/#/c/20010/6/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@34 PS6, Line 34: /** line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/6/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@36 PS6, Line 36: * API. This object is instantiated and governed by the backend line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20010/6/fe/src/main/java/org/apache/impala/util/IcebergMetadataScanner.java@38 PS6, Line 38: * line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/20010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0e943cecd77f5ef7af7cd07e2b596f2c5b4331e7 Gerrit-Change-Number: 20010 Gerrit-PatchSet: 6 Gerrit-Owner: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Anonymous Coward <lipeng...@apache.org> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gergely Fürnstáhl <g.furnst...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tma...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Sep 2023 10:17:22 +0000 Gerrit-HasComments: Yes