Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20496 )
Change subject: IMPALA-12373: Small String Optimization for StringValue ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/string-value.h File be/src/runtime/string-value.h: http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/runtime/string-value.h@76 PS4, Line 76: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/util/url-parser.cc File be/src/util/url-parser.cc: http://gerrit.cloudera.org:8080/#/c/20496/4/be/src/util/url-parser.cc@196 PS4, Line 196: (trimmed_url.Ptr()[key_pos - 1] != '?' && trimmed_url.Ptr()[key_pos - 1] != '&')) { line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/20496 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I741c3a5f12ab620b6b64b57d4c89b5f8e056efd3 Gerrit-Change-Number: 20496 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Sep 2023 15:20:04 +0000 Gerrit-HasComments: Yes
