Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19954 )
Change subject: IMPALA-12449: remove dependence on sse2neon ...................................................................... Patch Set 10: (2 comments) I think my preferred approach would be to duplicate the ARM POPCNT_popcnt_u64() definition in the section for LLVM IR. I compiled that locally and it works. http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/bit-util.h File be/src/util/bit-util.h: http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/bit-util.h@153 PS10, Line 153: uint64x1_t val = vcreate_u64(x); : uint8x8_t input_val = vreinterpret_u8_u64(val); : uint8x8_t count8x8_val = vcnt_u8(input_val); : return vaddv_u8(count8x8_val); Accompanying the change in sse-util.h, this would go back to POPCNT_popcnt_u64(x); http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/sse-util.h File be/src/util/sse-util.h: http://gerrit.cloudera.org:8080/#/c/19954/10/be/src/util/sse-util.h@296 PS10, Line 296: #define SSE4_crc32_u8 __crc32cb : #define SSE4_crc32_u16 __crc32ch : #define SSE4_crc32_u32 __crc32cw : #define SSE4_crc32_u64 __crc32cd This section is used for compiling the LLVM IR on ARM. If we duplicate the POPCNT_popcnt_u64 definition for ARM here, then that will fix the original compilation issue. I think I would prefer that, because it keeps the platform specific definitions to this file. I will file a follow-up JIRA to track untangling this file. -- To view, visit http://gerrit.cloudera.org:8080/19954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c78c877ef530fa9f35d36da523ad67ab34e5e7 Gerrit-Change-Number: 19954 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <s...@amazon.com> Gerrit-Reviewer: Anonymous Coward <s...@amazon.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Sep 2023 22:20:37 +0000 Gerrit-HasComments: Yes
