Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20505 )
Change subject: IMPALA-12462: Update only changed partitiones after COMPUTE STATS ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20505/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/20505/4/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@1891 PS4, Line 1891: !existingPartStats.equals(partitionStats) > There's some hidden cost here for the equals method as it may be doing an e For COMPUTE INCREMENTAL STATS (without partition spec), will all the partitions be in the params? If 'params' just have changed/new partitions, maybe this is not a big deal. -- To view, visit http://gerrit.cloudera.org:8080/20505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2703e0790d5c25db98ed26f26f6d96281c366a3 Gerrit-Change-Number: 20505 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Sep 2023 08:55:37 +0000 Gerrit-HasComments: Yes
