Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20507 )
Change subject: IMPALA-12460: Add lag and histogram of event processing in the log ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/20507/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20507/4//COMMIT_MSG@28 PS4, Line 28: jstacks. > adding automatic tests would be nice in the long run Yeah, need to inject some sleep time in event processing so we can better test the logs. http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@503 PS4, Line 503: dbName_ > maybe add "DB_WIDE "? It makes sense for ALTER_DATABASE events. But for CREATE_DATABASE or DROP_DATABASE, the db name looks better to me. http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/20507/4/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@947 PS4, Line 947: lastSyncedEventTime > shouldn't we print a warning only above some trashold? I think any lags should be taken care of. We have the above INFO log every second. This won't add too many logs comparing to that. -- To view, visit http://gerrit.cloudera.org:8080/20507 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9421b5e26bfa2324217ec9695fbd81636727d22 Gerrit-Change-Number: 20507 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 25 Sep 2023 14:58:10 +0000 Gerrit-HasComments: Yes
