Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/20523 )
Change subject: IMPALA-12477: Make Iceberg planFiles() use multiple threads ...................................................................... Patch Set 3: (2 comments) I read through quickly http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@378 PS3, Line 378: // Using a single-elment array to make the Java compiler happy. Otherwise it Nit: "element" http://gerrit.cloudera.org:8080/#/c/20523/3/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@384 PS3, Line 384: // thread. Maybe add: ... ", so the updates to dataFilesCacheMisses will not be done concurrently" (Did I understand correctly?) -- To view, visit http://gerrit.cloudera.org:8080/20523 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00db941dd5ac9917cd91d990fccf37e5bcfddbfc Gerrit-Change-Number: 20523 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 29 Sep 2023 17:47:55 +0000 Gerrit-HasComments: Yes
