Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/20475 )
Change subject: IMPALA-12444: Fix minimum parallelism bug in scan fragment ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20475/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/20475/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1065 PS1, Line 1065: long maxScannerThreads = Long.MAX_VALUE; > Done. Changed from long to int. Thanks for catching this! Please follow up below. http://gerrit.cloudera.org:8080/#/c/20475/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1108 PS1, Line 1108: (int) Math.min(costBasedMaxParallelism, maxScannerThreads)); Is the cast necessary here? http://gerrit.cloudera.org:8080/#/c/20475/1/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1139 PS1, Line 1139: maxParallelism_ = (int) Math.min(maxParallelism_, maxScannerThreads); Is the cast necessary here? -- To view, visit http://gerrit.cloudera.org:8080/20475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I69e5a80146d4ac41de5ef406fc2bdceffe3ec394 Gerrit-Change-Number: 20475 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 02 Oct 2023 16:04:10 +0000 Gerrit-HasComments: Yes
